fix: handle null date and timestamp format arguments#23641
Merged
Conversation
github-actions
Bot
added
sqllogictest
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23641 +/- ##
=======================================
Coverage ? 80.65%
=======================================
Files ? 1086
Lines ? 366105
Branches ? 366105
=======================================
Hits ? 295279
Misses ? 53230
Partials ? 17596 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jefffrey
approved these changes
Jul 17, 2026
alamb
approved these changes
Jul 17, 2026
| ColumnarValue::Scalar(scalar) => match scalar.try_as_str() { | ||
| Some(a) => { | ||
| let a = a.as_ref(); | ||
| // ASK: Why do we trust `a` to be non-null at this point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
to_date,to_timestamp, andto_unixtimefail on NULL string and format arguments #23640.Rationale for this change
The formatted
to_dateandto_timestamp*functions can produce internal errors when the input string is NULL or when all format arguments are NULL.A NULL value in a format column is also treated as an empty string instead of being skipped.
to_unixtimeuses the same timestamp parsing path, so it is affected as well.What changes are included in this PR?
Are these changes tested?
Yes, SLTs were added for
to_date,to_timestamp, andto_unixtime.Are there any user-facing changes?
Yes, only the bug fix described above. No API changes.